refactor: Remove separate default DetectorElementBase file
#2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DetectorElementBase.hpp` has an `ifdef` that either includes the preprocessor define or previously included the default base class header. We included that header in a numbr of locations by accident, breaking the pattern. This removes the separate header (and erroneous inlcudes) and puts the default interface into `DetectorElementBase.hpp` inside the `ifdef`.
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2617 +/- ##
=======================================
Coverage 49.53% 49.53%
=======================================
Files 473 473
Lines 26763 26763
Branches 12338 12338
=======================================
Hits 13257 13257
Misses 4753 4753
Partials 8753 8753
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
1 task
acts-project-service
added
the
Fails Athena tests
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
This PR rationalizes the documentation a bit. The main points are - Remove the documentation of the old standalone examples executables - Restructure the core documentation to be less sprawling - Move the figures from a central folder closer to the relevant source files - Remove the full auto API documentation in favor of a combination of hard-coded documented symbols + an auto detection mechanism to catch when we references symbols somewhere - This reduces the time it takes to build the docs drastically - Enable nitpicky generation, which will warn (and fail) if symbols are references that don't have a target. - [x] Try to auto-generate API listings only for the elements we explicitly call out by class / func roles. Blocked by: - #2616 - #2617 - #2624
paulgessinger
removed
the
Fails Athena tests
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Dec 21, 2023
In acts-project/acts#2617 the detail header will be removed.
7 tasks
github-merge-queue bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
Dec 21, 2023
### Briefly, what does this PR introduce? In acts-project/acts#2617 the detail header will be removed. ### What kind of change does this PR introduce? - [x] Bug fix (issue: Acts v31 compatibility) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
wdconinc
added a commit
to eic/EICrecon
that referenced
this pull request
Dec 23, 2023
### Briefly, what does this PR introduce? In acts-project/acts#2617 the detail header will be removed. ### What kind of change does this PR introduce? - [x] Bug fix (issue: Acts v31 compatibility) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DetectorElementBase.hpphas anifdefthat either includes the preprocessor define or previously included the default base class header. We included that header in a numbr of locations by accident, breaking the pattern. This removes the separate header (and erroneous inlcudes) and puts the default interface intoDetectorElementBase.hppinside theifdef.